Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ 1 Icon for Hive Social, the Twitter-like social media platform #2516

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ThatOneUnoriginal
Copy link

Added

Hive Social (org.hiveinc.TheHive.android)

First time contributing to this repository. I apologize if there are any blatant issues.

Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

Tip

While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR.

Lawnicons guidelines

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Jan 10, 2025
Originally went with 8, the minimum accepted stroke width because I was worried the smaller circle would look weird compared to the others. I don't think this'll happen so I've bumped it to the base 12.
@x9136
Copy link
Collaborator

x9136 commented Jan 10, 2025

The stroke width and color are chosen correctly, but there are many discrepancies with the Lawnicons guidelines.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Jan 10, 2025
@ThatOneUnoriginal
Copy link
Author

The stroke width and color are chosen correctly, but there are many discrepancies with the Lawnicons guidelines.

Could you point me in the right direction for which parts are inconsistent with the lawnicon guidelines?

This is my first time contributing to this so I may not immediately understand what is or isn't up to standards 100%

@RaduBratan
Copy link
Contributor

RaduBratan commented Jan 11, 2025

Hello. I'm not the original commenter but I could offer you some help with following the guidelines.

The first issue would be the positioning of the shapes. The content areas that you see in the guidelines have to be touched by your shapes, meaning the mouth has to be moved lower and to the right by a few pixels and the eyes have to be moved higher and to the left by some amount too, until the edges of the lines touch the canvas limits. Considering the type of icon you created (a non-square one) and the stroke of 12px, after realignment, the width and height of the icon should be exactly 148px (160px limit - 12px stroke = 148px), whereas yours is 146px.

The second issue would be the distances between strokes. This is mentioned in passing only once in the guidelines ("Avoid [...] close distances between strokes"), which is why it could be easy to miss and difficult to figure out how to implement. It could help to make the shapes slightly smaller, which combined with the aforementioned repositioning, it should increase the distances between the closest ends of any two strokes. In my opinion, a distance of 20px is the bare minimum, but my words aren't official.

There could also be an issue with the radius of some corners, specifically two found in the small eye and one at the left end of the mouth. However, I'm not 100% sure that those corners should be rounded, because the guidelines mention that only 90deg angles should use 6-32px in radius, whereas yours aren't exactly 90deg (the eyes have obtuse angles and the mouth has an acute one). So, I don't recommend rounding anything yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants