-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+ 1 Icon for Hive Social, the Twitter-like social media platform #2516
base: develop
Are you sure you want to change the base?
+ 1 Icon for Hive Social, the Twitter-like social media platform #2516
Conversation
Thanks for your contribution! We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly. Tip While waiting for a brief and strict review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. Additionally, you can find and install the debug build of your PR. Lawnicons guidelinesQuality
Canvas and sizes
Color, stroke width and rounding
Naming
|
Originally went with 8, the minimum accepted stroke width because I was worried the smaller circle would look weird compared to the others. I don't think this'll happen so I've bumped it to the base 12.
The stroke width and color are chosen correctly, but there are many discrepancies with the Lawnicons guidelines. |
Could you point me in the right direction for which parts are inconsistent with the lawnicon guidelines? This is my first time contributing to this so I may not immediately understand what is or isn't up to standards 100% |
Some error introduced when exporting from Figma to .svg, wasn't aware of it until now.
Hello. I'm not the original commenter but I could offer you some help with following the guidelines. The first issue would be the positioning of the shapes. The content areas that you see in the guidelines have to be touched by your shapes, meaning the mouth has to be moved lower and to the right by a few pixels and the eyes have to be moved higher and to the left by some amount too, until the edges of the lines touch the canvas limits. Considering the type of icon you created (a non-square one) and the stroke of 12px, after realignment, the width and height of the icon should be exactly 148px (160px limit - 12px stroke = 148px), whereas yours is 146px. The second issue would be the distances between strokes. This is mentioned in passing only once in the guidelines ("Avoid [...] close distances between strokes"), which is why it could be easy to miss and difficult to figure out how to implement. It could help to make the shapes slightly smaller, which combined with the aforementioned repositioning, it should increase the distances between the closest ends of any two strokes. In my opinion, a distance of 20px is the bare minimum, but my words aren't official. There could also be an issue with the radius of some corners, specifically two found in the small eye and one at the left end of the mouth. However, I'm not 100% sure that those corners should be rounded, because the guidelines mention that only 90deg angles should use 6-32px in radius, whereas yours aren't exactly 90deg (the eyes have obtuse angles and the mouth has an acute one). So, I don't recommend rounding anything yet. |
Added
Hive Social
(org.hiveinc.TheHive.android)
First time contributing to this repository. I apologize if there are any blatant issues.