Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metrics on AVS sync #38

Merged
merged 3 commits into from
May 15, 2024
Merged

Refactor metrics on AVS sync #38

merged 3 commits into from
May 15, 2024

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented May 14, 2024

Adds avs sync metrics to a Metrics struct and expose updates to such metrics through the metrics library.

Motivation

Solution

Open questions

@dmanc dmanc requested a review from samlaf May 14, 2024 00:41
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some nit comments.
Also didn't you say you want to start using loki log-derived metrics instead of using explicit metrics?

avssync/avssync.go Outdated Show resolved Hide resolved
avssync/metrics.go Outdated Show resolved Hide resolved
avssync/metrics.go Outdated Show resolved Hide resolved
avssync/metrics.go Outdated Show resolved Hide resolved
@dmanc
Copy link
Contributor Author

dmanc commented May 14, 2024

LGTM. Left some nit comments. Also didn't you say you want to start using loki log-derived metrics instead of using explicit metrics?

Need to think about it more, there's still value for having some metrics

@samlaf samlaf merged commit 7388343 into master May 15, 2024
1 check passed
@samlaf samlaf deleted the refactor-metrics branch May 15, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants