Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set AVS_SYNC_USE_FIREBLOCKS to false by default #42

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: set AVS_SYNC_USE_FIREBLOCKS to false by default #42

merged 1 commit into from
Jul 12, 2024

Conversation

renlulu
Copy link
Contributor

@renlulu renlulu commented Jul 4, 2024

Fixes # .

Motivation

Solution

Open questions

@samlaf
Copy link
Contributor

samlaf commented Jul 7, 2024

Seems reasonable. @ian-shim should we just change

avs-sync/flags.go

Line 84 in dbb01cb

UseFireblocksFlag = cli.BoolTFlag{
to be false by default instead of true by default?

@ian-shim
Copy link
Contributor

Yeah seems reasonable!

@samlaf samlaf merged commit 76cf373 into Layr-Labs:master Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renlulu @samlaf @ian-shim