Incorporate Uri's feedback

[samlaf]

Uri messaged me with this msg:

I read the code of the AVSSync and have minor comments from running the service pov:

• This line may be incorrect if there are errors in tryNTimesUpdateStakesOfEntireOperatorSetForQuorum.
• if I run the code in LogLevel info then I may not know which quorum had errors in fetching operator addresses .
• The code in tryNTimesUpdateStakesOfEntireOperatorSetForQuorum can be optimized, not to get the GetOperatorAddrsInQuorumsAtCurrentBlock if the update fails
  • this was not actually a bug, because the operator set might change between reading and writing, so we need to fetch the new set in case a race condition happened. added a comment to specify this.
• If I want to run the sync at midnight UTC, then every time I start the AVSSync I need to calculate the sleepBeforeFirstSyncDuration. You can help me by doing that calculation yourself.
  Instead of specifying the sleepBeforeFirstSyncDuration , I can specify the time (HH:MI:SS) which I want to run the sync. You can calculate the sleepBeforeFirstSyncDuration usign the interval and the time in day

Also simplified the run.sh script to use the env vars instead of passing flags explicitly.

[ian-shim]

why negate this one?
For binaries that are already running with this flag set to some value, it will have the opposite effect even if the configs are kept the same

[samlaf]

ehh good catch! I meant to also update the flag and env name of course!
I realized that binary flags' default is false and can't be set to true (other than dynamically in code, which I find ugly and bug prone), so I opted to do it this way because my assumption is that most everyone would want to update all of their quorums automatically without needing to restart avs-sync after adding a new quorum. So 2 questions for you:

• is that a valid assumption?
• if so, are you fine with this change? or do you have another suggestion for how to do this?

If you're fine with this, I will go ahead and fix the typo by making the flag --no-fetch-quorums-dynamically, as well as the env var name.

[ian-shim]

my assumption is that most everyone would want to update all of their quorums automatically

I think this assumption is fair. Would it be easier to keep the name the same but change the default to true by making it a cli.BoolTFlag?

[samlaf]

complete brains, I didn't even know BoolTFlag was an option! Reverted to this, thanks :) b5f5b41