Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMiddlewareTimesIndexBlock -> getMiddlewareTimesIndexStalestUpdateBlock #101

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Jul 17, 2023

This name looked like a typo (compare to getMiddlewareTimesIndexServeUntilBlock just below), so I fixed it to follow same name convention

@ChaoticWalrus
Copy link
Contributor

Makes sense to me. @gpsanant does this break any dependencies or are we good-to-go with it?

Copy link
Contributor

@gpsanant gpsanant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine

@gpsanant gpsanant merged commit ac143c1 into master Jul 17, 2023
9 checks passed
@gpsanant gpsanant deleted the fix-stalest-update-block-getter-name branch July 17, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants