fix: avs registrar interface #1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
approved these changes
Feb 12, 2025
|
LGTM - needs to pass CI + tests though. Is there a MW PR too? |
|
|
Seems like we're going with this one now? |
|
hotfix to dev here #1102 |
8sunyuan
added a commit
that referenced
this pull request
Feb 14, 2025
**Motivation:** Currently there is no way for an AVS implementing these callback functions of the IAVSRegistrar.sol to verify that the operatorSetIds belong to their operatorSets. The register/deregister callback functions are updated to include the address field. This PR is combining #1092 and #1085 Additionally, the try/catch design for deregistering from operatorSets was impacting state between AVS and core contracts due to not having proper gas estimates when submitting transactions. Solutions exploring passing some suitable gas paramter were explored but eventually removing it entirely was deemed the best solution. **Modifications:** - Added `avs()` view function that is checked upon `setAVSRegistrar` - added `address avsIdentifier` field in the callbacks, this should match the `avs()` view function on the AVSRegistrar - Removed try catch on `deregisterForOperatorSets` **Result:** AVSRegistrars cannot be used for multiple operatorSets and AVSRegistrars can doublecheck to verify that a register/deregister callback is correctly called for their contracts. Registration state between AVS and Eigenlayer core contracts for OperatorSets are now done in atomic transactions (if entrypoint is always through the AllocationManager)
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
**Motivation:** Currently there is no way for an AVS implementing these callback functions of the IAVSRegistrar.sol to verify that the operatorSetIds belong to their operatorSets. The register/deregister callback functions are updated to include the address field. This PR is combining #1092 and #1085 Additionally, the try/catch design for deregistering from operatorSets was impacting state between AVS and core contracts due to not having proper gas estimates when submitting transactions. Solutions exploring passing some suitable gas paramter were explored but eventually removing it entirely was deemed the best solution. **Modifications:** - Added `avs()` view function that is checked upon `setAVSRegistrar` - added `address avsIdentifier` field in the callbacks, this should match the `avs()` view function on the AVSRegistrar - Removed try catch on `deregisterForOperatorSets` **Result:** AVSRegistrars cannot be used for multiple operatorSets and AVSRegistrars can doublecheck to verify that a register/deregister callback is correctly called for their contracts. Registration state between AVS and Eigenlayer core contracts for OperatorSets are now done in atomic transactions (if entrypoint is always through the AllocationManager)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently there is no way for an AVS implementing these callback functions of the
IAVSRegistrar.solto verify that the operatorSetIds belong to their operatorSets. This is because AVSRegistrar configuration does not have uniqueness and implementing uniqueness in the AllocationManager is not feasible due to frontrunning DOS vectors for existing AVSs.Modifications:
IAVSRegistrar.solinterfaceResult: