Permissioned operator churn #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
64
to
67
| /// @notice the address of the entity allowed to sign off on operators getting kicked out of the AVS during registration | ||
| address public churner; | ||
| /// @notice the nonce of the churner used in EIP-712 signatures | ||
| uint256 public churnerNonce; |
There was a problem hiding this comment.
for naming: the description suggests that this entity is really a churnApprover or similar.
am also thinking that 'salts' may make more sense than nonces here, but we can debate a bit -- the intended usage is important to consider
There was a problem hiding this comment.
Changed to churn approver, would prefer to keep the nonce logic for now since we expect this to not have many race conditions
There was a problem hiding this comment.
agreed offline that salt is more flexible here / nonce is not needed
Comment on lines
89
to
90
| // set the churner | ||
| churner = _churner; |
There was a problem hiding this comment.
should presumably have an event associated to this
|
Gave some quick input on this PR. @gpsanant can you provide a brief summary of test changes / updates here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added churner role and tests for it
Tests summary/updates: