Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: StrategyManager Unit testing #224

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Feat: StrategyManager Unit testing #224

merged 9 commits into from
Oct 12, 2023

Conversation

8sunyuan
Copy link
Collaborator

@8sunyuan 8sunyuan commented Oct 5, 2023 •
edited
Loading

Additional Unit Tests:

  • Fixed commented out tests
  • improved fuzzing
  • added additional coverage

Update:

  • Fixing broken tests from withdrawal changes to StrategyManager and DelegationManager
  • comprehensive withdrawals tests including both EPM and SM withdrawals should be written later

@8sunyuan 8sunyuan mentioned this pull request Oct 5, 2023
Closed
ChaoticWalrus
ChaoticWalrus reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like improvements all around.
This will definitely have conflicts with #222
I feel like it might actually make more sense to try merging from this branch into that one (or vice versa?) rather than merging either PR into master first.
Let me know your thoughts; I'm sure we can sort things out.

@8sunyuan
Copy link
Collaborator Author

8sunyuan commented Oct 6, 2023

LGTM, seems like improvements all around. This will definitely have conflicts with #222 I feel like it might actually make more sense to try merging from this branch into that one (or vice versa?) rather than merging either PR into master first. Let me know your thoughts; I'm sure we can sort things out.

Yeah I agree, I'll merge #222 into this branch, resolve conflicts then rebase.

@8sunyuan 8sunyuan changed the base branch from master to Combined-Withdrawal-Flow-No-Limbo October 6, 2023 19:56
Base automatically changed from Combined-Withdrawal-Flow-No-Limbo to master October 11, 2023 18:45
@stevennevins
Copy link
Contributor

stevennevins commented Oct 12, 2023 •
edited
Loading

Great work on handling all the upstream changes here. Can you add a couple of tests for addShares and removeShares where you prank the MockDelegationManager to ensure the updates happen accurately?

@ChaoticWalrus ChaoticWalrus merged commit 4a5ca56 into master Oct 12, 2023
7 of 11 checks passed
@ChaoticWalrus ChaoticWalrus deleted the feat/strategy-manager-unit-tests branch October 12, 2023 21:45
@ChaoticWalrus
Copy link
Contributor

Merging this PR for now, as it seems in a good place / well-reviewed.

Great work on handling all the upstream changes here. Can you add a couple of tests for addShares and removeShares where you prank the MockDelegationManager to ensure the updates happen accurately?

I agree these tests would be good to add, which can be done in a following PR 😄

@8sunyuan 8sunyuan mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticWalrus ChaoticWalrus ChaoticWalrus left review comments

@stevennevins stevennevins stevennevins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8sunyuan @stevennevins @ChaoticWalrus