Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegated accounts custom errors #832

Open
wants to merge 2 commits into
base: custom-errors
Choose a base branch
from
Open

Delegated accounts custom errors #832

wants to merge 2 commits into from

Commits on Oct 17, 2024

  1. Added: 

    1) Interface for composable permission controller.
2) Storage layout for permission controller.
3) Initial implementation for controller.

I also added a library for a bytes4 enumerable set, since OZ didn't have
one. We do this so people can easily inspect which permissions on which
contracts people have. We could also add an index for which contracts
have permissions, but I figured that getting the list of important
addresses (core contracts + AVS contracts) would be far more legibile
off-chain. We could maintain it on chain and provide that list of
contracts, and quite frankly it would be great because then you could
determine ALL permissions that a user had simply with view functions. I
might add this incrementally if we can align on the basics here.
    @scotthconner @ypatil12
    scotthconner authored and ypatil12 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8977fd5 View commit details
    Browse the repository at this point in the history

  2. Forgot to emit the state change event.

    @scotthconner @ypatil12
    scotthconner authored and ypatil12 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6d96106 View commit details
    Browse the repository at this point in the history