slashing: fully slashed strategies #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
8sunyuan
force-pushed
the
slashing-cleanup
branch
from
3ddef4b
to
f939ead
Compare
8sunyuan
force-pushed
the
fully-slashed-strategies
branch
from
2307456
to
c224c7a
Compare
|
ypatil12
approved these changes
Oct 24, 2024
| * if this is the beaconChain strategy | ||
| * @return bool True if the maxMagnitude is not 0 and the staker's beaconChainScalingFactor is not 0 | ||
| */ | ||
| function _verifyMaxMagnitudeAndScalingFactor( |
There was a problem hiding this comment.
Nit: Perhaps call this hasNonZeroScalingFactors since it returns a bool
| /// Slashing | ||
|
|
||
| /// @dev Thrown when an operator has been fully slashed(maxMagnitude is 0) for a strategy. | ||
| /// or if the staker has had been natively slashed to the point of their beaconChainScalingFactor equalling 0. |
There was a problem hiding this comment.
Can we add to documentation somewhere that:
- A staker can always redelegate for any strategy if the
maxMagnitudeis 0 - A staker can never delegate for beacon chain strategy if they are fully slashed on the beacon chain.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles edge cases of 100% slashed scenarios where an operator is fully slashed for a strategy(maxMagnitude = 0)
and also when a native restaker has had enough accrued delta decreases in their beacon chain shares to the point where their beaconChainScalingFactor is 0. Either of these situations will result in a divide by 0 and has more transparent error revert checks when this occurs.
Changes:
increaseDelegatedShares) to an operator for a strategy that is fully slashed will revertNote: Complete queued withdrawals are unchanged but perhaps should revert if they were slashed during queue delay. It would avoid wasted gas for withdrawing 0 shares.
Tests:
increaseDelegatedShares) will revertincreaseDelegatedSharesfor other strategies with non-zero maxMagnitude for the operator.