Unit test bls op state ret #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eratorStake_Reverts
…talStake_Reverts and make kicking not have to be for every joining quorum
ChaoticWalrus
requested changes
Jul 13, 2023
There was a problem hiding this comment.
This is looking really good.
I believe I've gone through everything & I've added a bunch of comments, but it is primarily minor stuff.
@gpsanant Do we have tracking of these unit test cases somewhere? I find it very hard to visualize or understand coverage when just reviewing code like this.
ChaoticWalrus
approved these changes
Jul 18, 2023
|
LGTM now. I believe we've resolved all my questions; there's a couple cans that we're kicking down the road a little but we've at least aligned on these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO