fix: handle eject operators correctly for post try-catch #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8sunyuan
reviewed
Feb 14, 2025
There was a problem hiding this comment.
_deregisterOperator should have the _forceDeregister and shouldForceDeregister input removed and only be called in the callback function
I think the following functions have _deregisterOperator calls and need to be updated with _forceDeregister.
_registerOperatorWithChurn_updateStakesAndDeregisterLoiterers(this can be cleaned up a bit and renamed)
There was a problem hiding this comment.
Ahh good call. Will update for those as well
There was a problem hiding this comment.
We can probably remove the loiterers concept now since there isn't a risk of the registration status being out sync?
And we can combine churn with ejection on the implementation side
There was a problem hiding this comment.
Yup no more loiterers :)
There was a problem hiding this comment.
Updated @8sunyuan
stevennevins
changed the base branch from
test/slashing-release
to
feat/avs-identifier-src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ejectOperator in SlashingRegistryCoordinator now only uses _forceDeregisterOperator, allowing AllocationManager to handle callbacks for deregistration
RegistryCoordinator now handles M2 and non-M2 quorums separately:
M2 quorums use _deregisterOperator
Non-M2 quorums use _forceDeregisterOperator
Added bitmap intersection support to filter quorum types properly
This change improves the ejection flow by ensuring proper deregistration handling through the AllocationManager while maintaining special handling for M2 quorums on ejection