Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixify #86

Merged
merged 2 commits into from
Oct 31, 2024
Merged

nixify #86

merged 2 commits into from
Oct 31, 2024

Conversation

kayvank
Copy link
Contributor

@kayvank kayvank commented Oct 9, 2024 •
edited
Loading

Add nix related artifacts to make project build in nixos

to verify:

$ nix develop
$ npm run build
$ npm run anvil
$ npm run deploy:core
$ npm run deploy:hello-world
$ npm run extract:abis

this is for issue #74

@kayvank kayvank mentioned this pull request Oct 9, 2024
Open
@stevennevins
Copy link
Collaborator

@kayvank Thanks for this PR. overall, it does lgtm. I will take a deeper look and run through the commands tomorrow am

eigen-vi
eigen-vi reviewed Oct 11, 2024
View reviewed changes
Copy link

@eigen-vi eigen-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for sending this in! i've left a few comments if you'd be able to take a look

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@kayvank kayvank requested a review from eigen-vi October 12, 2024 01:36
supernovahs
supernovahs reviewed Oct 16, 2024
View reviewed changes
rust-toolchain.toml Outdated Show resolved Hide resolved
eigen-vi
eigen-vi reviewed Oct 16, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
eigen-vi
eigen-vi approved these changes Oct 30, 2024
View reviewed changes
Copy link

@eigen-vi eigen-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix lgtm, will defer to others here on the rust and node toolchain parts

@stevennevins
Copy link
Collaborator

can you merge in the latest updates / rebase just to confirm CI passes

@kayvank
nixify
1561d18 
Add nix related artifacts to make project build in nixos
@kayvank
Copy link
Contributor Author

kayvank commented Oct 30, 2024

@stevennevins could this be merged now, please? I belive all PR comments are taken care of.

@supernovahs
Copy link
Contributor

can you add nix install instructions?

@kayvank
Copy link
Contributor Author

kayvank commented Oct 30, 2024

can you add nix install instructions?

@supernovahs added the nix related docs

@kayvank
nixfy
e363c8b 
Add Nix related documentation
@kayvank
Copy link
Contributor Author

kayvank commented Oct 31, 2024

@stevennevins could this be merged? All PR comments are taken care of.

@stevennevins stevennevins merged commit 2ba9054 into Layr-Labs:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevennevins stevennevins stevennevins approved these changes

@supernovahs supernovahs supernovahs approved these changes

@eigen-vi eigen-vi eigen-vi approved these changes

@wesfloyd wesfloyd Awaiting requested review from wesfloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kayvank @stevennevins @supernovahs @eigen-vi