feat: Deprecate usage of `@eigenda/utils` in-favor of `@eigenda/contracts` #46

ethenotethan · 2025-02-11T20:10:14Z

Summary: Deprecate @eigenda/utils library to use @eigenda/contracts instead. This is a major refactor and gets rid of a lot of custom code in-favor of the new EigenDACertVerifier contract.

Changes:

Remove local deployment scripts
Scrap blob verifier contracts and make verification optional within the sequencer inbox.
Replace rollupManager usage with eigenDACertVerifier
Regenerate storage and function signature mappings

…loying fork summaries

…ndry fmt

…st file

…pts && add code comments

…s from 2d95b36

…ences to use eigenDACertVerifier

…eflect latest foundry

…gnatures

samlaf

quick skim review

scripts/config.ts.example

samlaf · 2025-02-12T22:21:41Z

scripts/deploymentUtils.ts

+  const eigenDACertVerifier = IEigenDACertVerifier__factory.connect(
+    eigenDACertVerifierAddress,
+    signer
+  )


why arent you deploying a new certverifier instead? think we want each rollup to manage its own certverifier goingh forward

was hoping the actual EigenDACertVerifier deployment would be a separate script managed in the eigenda monorepo so we wouldn't have manage dual implementations across smart contract dev frameworks (i.e, hardhat, foundry)

cc - @0x0aa0

so what's the overall flow for deploying these contracts for a nitro chain? I won't lie I don't really understand whats happening in this PR

samlaf · 2025-02-12T22:22:41Z

src/bridge/SequencerInbox.sol

    // gap used to ensure forward compatiblity with newly introduced storage variables
    // from upstream offchainlabs/nitro-contracts. Any newly introduced storage vars
    // made in subsequent releases should result in decrementing the gap counter
    uint256[38] internal __gap;
-    IRollupManager public eigenDARollupManager;
+    IEigenDACertVerifier public eigenDACertVerifier;
+    uint256 internal constant MAX_EIGENDA_CERTIFICATE_DRIFT = 100;


we need to standardize on this name across integration. lets add it to spec?

sounds good

added link in spec https://www.notion.so/EigenDA-V2-Integration-Spec-12d13c11c3e0800e8968f31ef2c6a2b3?d=19c13c11c3e080789d99001c88cd090f&pvs=4#18813c11c3e080668187c5de4355cbeb
Now I'm not even sure we need this thing in op stack... can you check my comment there?

src/bridge/SequencerInbox.sol

samlaf · 2025-02-12T22:23:36Z

src/bridge/SequencerInbox.sol

+    //  (B) integrity: A cert must be correct regarding its (quorums, thresholds) & successfully
+    //                 correlate to an EigenDA batch merkle root persisted on the service manager


@bxue-l2 separates these as integrity and something else

@bxue-l2 please enlighten me on the nomenclature 🙏🏻

Here is my system of words. Signature/quorum checking is something I call validity check, which described if this is a valid eigenda blob. If a cert is invalid, then you got an empty byte. If a cert is valid, then you can proceed to the next phase of integrity checks.

Integrity is another word I used for eigenda blob processing. It includes, removing empty byte, taking fft, check lengths, etc. https://en.wikipedia.org/wiki/Data_integrity

That's interesting. I feel like I would have swapped those 2 words:

integrity: has to do with being honest, so an invalid cert would be one that has a wrong signature or something (eigenda validators tried to lied)

validity: kind of applies to whatever, so we could just say that the blob is valid wrt the cert

samlaf · 2025-02-12T22:25:31Z

test/signatures/RollupCore

guessing these are autogenerated? theres a .gitattributes file that they can be added to to not appear in PR reviews

hmm I think we may want them explicitly captured

I mean they are still committed and part of the PR, just that the github UI will collapse them to indicate that they prob don't need to be reviewed (should be guarded by CI anyways)

I would argue they would need to be reviewed

…comment

0x0aa0 · 2025-02-13T21:07:45Z

test/storage/SequencerInbox

-| eigenDARollupManager        | contract IRollupManager                                  | 9    | 0      | 20    | src/bridge/SequencerInbox.sol:SequencerInbox |
-| isSequencer                 | mapping(address => bool)                                 | 10   | 0      | 32    | src/bridge/SequencerInbox.sol:SequencerInbox |
-| delayBlocks                 | uint64                                                   | 11   | 0      | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
-| futureBlocks                | uint64                                                   | 11   | 8      | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
-| delaySeconds                | uint64                                                   | 11   | 16     | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
-| futureSeconds               | uint64                                                   | 11   | 24     | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
-| batchPosterManager          | address                                                  | 12   | 0      | 20    | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| isSequencer                 | mapping(address => bool)                                 | 9    | 0      | 32    | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| delayBlocks                 | uint64                                                   | 10   | 0      | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| futureBlocks                | uint64                                                   | 10   | 8      | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| delaySeconds                | uint64                                                   | 10   | 16     | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| futureSeconds               | uint64                                                   | 10   | 24     | 8     | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| batchPosterManager          | address                                                  | 11   | 0      | 20    | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| __gap                       | uint256[38]                                              | 12   | 0      | 1216  | src/bridge/SequencerInbox.sol:SequencerInbox |
+|-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------|
+| eigenDACertVerifier         | contract IEigenDACertVerifier                            | 50   | 0      | 20    | src/bridge/SequencerInbox.sol:SequencerInbox |
+╰-----------------------------+----------------------------------------------------------+------+--------+-------+----------------------------------------------╯


looks like storage layout shifted here

@0x0aa0 iiuc that shouldn't matter since we won't be supporting an upgrade to this change

… into epociask--feat-updated-eigenda-contracts

…signature

ethenotethan added 23 commits December 22, 2024 18:56

fix: CI

6f0767c

fix: CI - bump back

a6bb829

fix: CI - update test E2E script to use eigenda deploy params

824b5c5

fix: CI - use GH native workers (ie ubuntu-latest)

c95d0fa

feat: Fork diff

d5f0a38

feat: Add fork diff summary - updated CI

e2f5286

feat: Fork Diff Summary - remove index.html and add CI action for dep…

d39d46d

…loying fork summaries

feat: Fork Diff Summary - update fork ref to eigenda branch

2442c6d

feat: Fork Diff Summary - run yarn lint

1b09621

feat: Fork Diff Summary - disable tests that are also disabled upstream

ef7e5f2

feat: Fork Diff Summary - update deploy params in arbRollup spec

b67d2be

feat: Fork Diff Summary - update storage layout to reflect latest fou…

86bca8e

…ndry fmt

feat: Fork Diff Summary - update sigs

b00c479

feat: Fork Diff Summary - update CI test comments

d91d871

feat: Fork Diff Summary - update slither action

84ed6a9

feat: Fork Diff Summary - address pr feedback

2d95b36

feat(v2.1.0): Use up-to-date @eigenda/contracts

30a6be2

feat(v2.1.0): Use up-to-date @eigenda/contracts - rm blob verifier te…

509e652

…st file

feat(v2.1.0): Use up-to-date @eigenda/contracts - rm unnecessary scri…

7401349

…pts && add code comments

feat(v2.1.0): Use up-to-date @eigenda/contracts - incorporate CI fixe…

33347c0

…s from 2d95b36

feat(v2.1.0): Use up-to-date @eigenda/contracts - update script refer…

6342846

…ences to use eigenDACertVerifier

feat(v2.1.0): Use up-to-date @eigenda/contracts - update testing to r…

ae85a05

…eflect latest foundry

feat(v2.1.0): Use up-to-date @eigenda/contracts - updated contract si…

4dab172

…gnatures

ethenotethan requested review from samlaf and 0x0aa0 February 12, 2025 08:24

samlaf reviewed Feb 12, 2025

View reviewed changes

feat(v2.1.0): Use up-to-date @eigenda/contracts - update cert verify …

58cde96

…comment

ethenotethan requested a review from samlaf February 13, 2025 06:34

feat(v2.1.0): Use up-to-date @eigenda/contracts - yarn fmt

38dbd3f

This comment was marked as outdated.

Sign in to view

0x0aa0 reviewed Feb 13, 2025

View reviewed changes

ethenotethan requested a review from 0x0aa0 February 14, 2025 16:41

ethenotethan changed the base branch from eigenda-v2.1.0 to eigenda-v2.1.3 February 18, 2025 13:23

ethenotethan added 3 commits February 18, 2025 20:27

Merge branch 'eigenda-v2.1.3' of github.com:layr-labs/nitro-contracts…

2d5402c

… into epociask--feat-updated-eigenda-contracts

feat(v2.1.3): Use up-to-date @eigenda/contracts - update foundry.toml

daf45ff

feat(v2.1.3): Use up-to-date @eigenda/contracts - update ERC20Bridge …

0c9a507

…signature

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Deprecate usage of `@eigenda/utils` in-favor of `@eigenda/contracts` #46

feat: Deprecate usage of `@eigenda/utils` in-favor of `@eigenda/contracts` #46

ethenotethan commented Feb 11, 2025 •

edited

Loading

samlaf left a comment

samlaf Feb 12, 2025

ethenotethan Feb 13, 2025

samlaf Feb 16, 2025

samlaf Feb 12, 2025

ethenotethan Feb 13, 2025

samlaf Feb 16, 2025

samlaf Feb 12, 2025

ethenotethan Feb 13, 2025

bxue-l2 Feb 17, 2025 •

edited

Loading

samlaf Feb 17, 2025

samlaf Feb 12, 2025

ethenotethan Feb 13, 2025

samlaf Feb 16, 2025

ethenotethan Feb 18, 2025

This comment was marked as outdated.

0x0aa0 Feb 13, 2025

ethenotethan Feb 14, 2025

		// (B) integrity: A cert must be correct regarding its (quorums, thresholds) & successfully
		// correlate to an EigenDA batch merkle root persisted on the service manager

feat: Deprecate usage of @eigenda/utils in-favor of @eigenda/contracts #46

Are you sure you want to change the base?

feat: Deprecate usage of @eigenda/utils in-favor of @eigenda/contracts #46

Conversation

ethenotethan commented Feb 11, 2025 • edited Loading

samlaf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bxue-l2 Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat: Deprecate usage of `@eigenda/utils` in-favor of `@eigenda/contracts` #46

feat: Deprecate usage of `@eigenda/utils` in-favor of `@eigenda/contracts` #46

ethenotethan commented Feb 11, 2025 •

edited

Loading

bxue-l2 Feb 17, 2025 •

edited

Loading