pointer in main only

LdDl · Oct 22, 2024 · c15d963 · c15d963
1 parent 32cedea
commit c15d963
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/cmd/video_server/main.go b/cmd/video_server/main.go
@@ -48,7 +48,7 @@ func main() {
 		}
 		defer pprof.StopCPUProfile()
 	}
-	appCfg, err := configuration.PrepareConfiguration(conf)
+	appCfg, err := configuration.PrepareConfiguration(*conf)
 	if err != nil {
 		log.Error().Err(err).Str("scope", videoserver.SCOPE_CONFIGURATION).Msg("Could not prepare application configuration")
 		return

diff --git a/configuration/prepare.go b/configuration/prepare.go
@@ -7,29 +7,29 @@ import (
 	"github.com/pkg/errors"
 )
 
-func PrepareConfiguration(confName *string) (*Configuration, error) {
+func PrepareConfiguration(confName string) (*Configuration, error) {
 	var err error
-	if confName == nil || *confName == "" {
+	if confName == "" {
 		errReason := "Empty file name"
 		return nil, errors.Wrap(err, errReason)
 	}
 
-	fileNames := strings.Split(*confName, ".")
+	fileNames := strings.Split(confName, ".")
 	if len(fileNames) != 2 {
-		errReason := fmt.Sprintf("Bad file name '%s'", *confName)
+		errReason := fmt.Sprintf("Bad file name '%s'", confName)
 		return nil, errors.Wrap(err, errReason)
 	}
 	fileFormat := fileNames[1]
 
 	switch fileFormat {
 	case "json":
-		mainCfg, err := PrepareConfigurationJSON(*confName)
+		mainCfg, err := PrepareConfigurationJSON(confName)
 		if err != nil {
 			return nil, err
 		}
 		return mainCfg, nil
 	case "toml":
-		mainCfg, err := PrepareConfigurationTOML(*confName)
+		mainCfg, err := PrepareConfigurationTOML(confName)
 		if err != nil {
 			return nil, err
 		}