Only set content-type to urlencoded when data is string or URLSearchParams (#208) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
So I shouldn't merge this? Or you mean #208? |
|
Rebased to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #208.
Testing coverage is very limited (changes are semantical more than functional). This is due to sinon.js mock XHR server only supporting strings (This is still the case in the newest version). In other words this PR addresses #208, but not #200. I suggest we leave #200 open, hoping someone else has an idea of how to deal with it. The tests still work (and also would have if I hadn't changed them). They're just lacking coverage.