feat: User is now prompted to enter credentials if there's no config file or it's filled with default information #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r it's filled with default information Fixed some typos
dfasaAZ
changed the title
LeagueOfPoro
requested changes
Feb 15, 2023
No more duplication of 'accounts' section
|
Cool idea and looks okay to me, but for the typical user the config helper webfile is more than enough. Unnecessary PoF and maintenance. |
True. Maybe something simple as a link to the config helper would be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
If program can't find existing config.yaml file, user will be prompted to create one and fill via command line(password input is hidden)
Same for default config file (you can see multiple account creation on the screenshot below)
Case where config.yaml is empty
Additional context
Fixed some typos in comments and created UserPrompt function to handle dialog with user
Testing instructions
Account creation should work in all scenarios
User prompt should accept all variants of "yes"
How to download the PR for testing
gh pr checkout 124(Requires GitHub CLI)