feat: Improve UI layout #189 #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout has -Info Table -conditional Update Table -Accounts Table -Matches Table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189
Summary of Changes
I have changed how the GuiThread handles and displays the statistics. I have also moved the Text that was before printed above the Live stats and the update notice to the GuiThread.
The GuiThread now creates four different tables and unites them in one layout which is then displayed in the console.
The Tables are:
-Info Table
-Update Table (which only displays when an update is available)
-Accounts Table (which shows the per-account infos about last drop, last heartbeat, sessionDrops, etc...)
-Matches Table (which shows all the currently running live matches and their status per account)
Additional context
Discord username (if different from GitHub): TheKempter#7648
Testing instructions
How to download the PR for testing
Using GitHub CLI
gh pr checkout 199(Requires GitHub CLI)Using regular GIT
git fetch origin pull/199/head:improve_ui_layout_#189git checkout improve_ui_layout_#189