Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker table display #56

Merged

Conversation

DjordyKoert
Copy link
Contributor

See this issue on the discord: https://discord.com/channels/493691955184926720/1071031553460817990/1071483509874634802

Fixes docker container not being able to show the table (does not look optimal but so be it I guess)

Disclaimer

This is code has already been applied on my own "fork". The commit can be found here.

I am running the CapsuleFarmerEvolved on docker and viewing the logs through portainer now looks like this:
image

@DjordyKoert
Copy link
Contributor Author

Still contains file changes from #52. These should be gone after merging of that PR

@DjordyKoert DjordyKoert changed the title feat: Fix/docker table display fix: docker table display Feb 4, 2023
@alepouna alepouna added the enhancement New feature or request label Feb 5, 2023
@alepouna alepouna marked this pull request as draft February 5, 2023 00:28
@alepouna alepouna marked this pull request as ready for review February 5, 2023 00:28
@alepouna alepouna added the DoNotMerge PR should not be merged if it has this label in label Feb 7, 2023
@DjordyKoert
Copy link
Contributor Author

@auroraisluna DoNotMerge label can be removed

@alepouna alepouna requested a review from LeagueOfPoro February 7, 2023 20:35
@alepouna alepouna removed the DoNotMerge PR should not be merged if it has this label in label Feb 7, 2023
@alepouna
Copy link
Collaborator

alepouna commented Feb 8, 2023

LGTM, waiting for poro.

@LeagueOfPoro LeagueOfPoro merged commit 5c8b5aa into LeagueOfPoro:master Feb 8, 2023
@DjordyKoert DjordyKoert deleted the fix/docker-table-display branch February 8, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants