bin support #6
Merged
bin support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: unimplemented comment in struct writer
moonshadow565
approved these changes
Oct 23, 2024
|
Tentatively marking bin writing as complete, round trip test is working but won't be confident in its soundness until I dogfood it more with hexbelt or something |
|
Is it ready to merge then ? |
Yeah I'd say so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has the commits from #5, so not mergable until that is closed. There are also still some improvements that can be made - it would be nice to reduce the boilerplate around PropertyValueEnum more.