MuSig2 support #294
MuSig2 support #294
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // int pk_offset = is_tap ? 1 : 0; | ||
| // if (memcmp(pubkey.compressed_pubkey + pk_offset, bip32_derivation_pubkey, key_len) != 0) | ||
| // { | ||
| // return 0; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
- Coverage 84.76% 84.67% -0.10%
===========================================
Files 17 17
Lines 2186 2231 +45
===========================================
+ Hits 1853 1889 +36
- Misses 333 342 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
…icies to more general key expressions
…ed some comments. Generalizing to key expressions containing musig() makes it necessary to distinguish the key expressions in the wallet policy from the actual key placeholders that are just indexes to the list of key informations (@num in the descriptor template), whereas the two concepts were often not clearly separated in the code base. Renaming to "key expressions" makes the distinction more clear.
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
…ues in sign_psbt in the python client
- musig() now sorts the keys, as per the BIP draft - correctly compute fingerprint for musig() aggregate key - added both the aggregate and the internal key in keyexpr_info_t struct - fixed psbt parsing logic to detect change/addr_index for musig - updated musig tests
…ting prematurely for some PSBTs. Added explanatory comment
…ey_placeholders, with musig placeholder support
Closes: #208