Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first declarative utils [LIVE-9138] #265

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat: first declarative utils [LIVE-9138] #265

merged 3 commits into from
Nov 24, 2023

Conversation

Justkant
Copy link
Collaborator

No description provided.

@Justkant Justkant requested a review from a team November 22, 2023 09:17
@Justkant Justkant self-assigned this Nov 22, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1b1ed74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 2:22pm
wallet-api-wallet-api-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 2:22pm

@Justkant
test: add RTL to nextjs example
b8cc4c1 
add setTimeout in the simulator transport to better simulate async calls and support RTL tests
cleanup declarativeHandlers call and issues with types
export declarativeHandlers function
@Justkant
test: update test name
1b1ed74
ComradeAERGO
ComradeAERGO approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Justkant Justkant merged commit 7d3cdca into main Nov 24, 2023
2 checks passed
@Justkant Justkant deleted the feat/declarativeSimulator branch November 24, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeAERGO ComradeAERGO ComradeAERGO approved these changes

Assignees

@Justkant Justkant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justkant @ComradeAERGO