Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exchange): add optional tokenCurrency [LIVE-10291] #266

Merged
merged 4 commits into from
Nov 28, 2023
Merged

feat(exchange): add optional tokenCurrency [LIVE-10291] #266

merged 4 commits into from
Nov 28, 2023

Conversation

Justkant
Copy link
Collaborator

@Justkant Justkant commented Nov 23, 2023 •
edited
Loading

Add an optional tokenCurrency field for the swap and fund

JIRA: https://ledgerhq.atlassian.net/browse/LIVE-10291

@Justkant Justkant requested a review from a team November 23, 2023 16:15
@Justkant Justkant self-assigned this Nov 23, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 33c5dd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@ledgerhq/wallet-api-client Minor
@ledgerhq/wallet-api-server Minor
@ledgerhq/wallet-api-core Minor
@ledgerhq/wallet-api-client-react Patch
@ledgerhq/wallet-api-simulator Patch
client-nextjs Patch
@ledgerhq/wallet-api-manifest-validator-cli Patch
@ledgerhq/wallet-api-manifest-validator Patch
wallet-api-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 8:43am
wallet-api-wallet-api-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 8:43am

@Justkant Justkant force-pushed the feat/exchangeTokenCurrency branch from 85c431c to 7994dd9 Compare November 24, 2023 09:10
@Justkant Justkant changed the title feat(exchange): add optional tokenCurrency feat(exchange): add optional tokenCurrency [LIVE-10240] Nov 24, 2023
@Justkant Justkant changed the title feat(exchange): add optional tokenCurrency [LIVE-10240] feat(exchange): add optional tokenCurrency [LIVE-10291] Nov 27, 2023
@sarneijim sarneijim self-requested a review November 27, 2023 17:26
sarneijim
sarneijim reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@sarneijim sarneijim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some documentation. Feel free to amend it.
LGTM!

@sarneijim sarneijim self-requested a review November 27, 2023 17:27
@sarneijim sarneijim mentioned this pull request Nov 27, 2023
Merged
Justkant
Justkant commented Nov 28, 2023
View reviewed changes
spec/rpc/README.md Outdated Show resolved Hide resolved
@Justkant Justkant merged commit 746a6ab into main Nov 28, 2023
2 checks passed
@Justkant Justkant deleted the feat/exchangeTokenCurrency branch November 28, 2023 08:47
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarneijim sarneijim sarneijim approved these changes

Assignees

@Justkant Justkant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justkant @sarneijim