Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve custom handler types [LIVE-9760] #274

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Justkant
Copy link
Collaborator

@Justkant Justkant commented Dec 5, 2023

Still missing some examples of usage and docs on how to setup the type safety in a project

@Justkant Justkant requested a review from a team December 5, 2023 09:15
@Justkant Justkant self-assigned this Dec 5, 2023
Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: ced6647

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@ledgerhq/wallet-api-client-react Minor
@ledgerhq/wallet-api-client Minor
@ledgerhq/wallet-api-core Minor
client-nextjs Patch
@ledgerhq/wallet-api-simulator Patch
@ledgerhq/wallet-api-manifest-validator-cli Patch
@ledgerhq/wallet-api-manifest-validator Patch
@ledgerhq/wallet-api-server Patch
wallet-api-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 3:46pm
wallet-api-wallet-api-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 3:46pm

@Justkant Justkant merged commit a466649 into main Dec 7, 2023
2 checks passed
@Justkant Justkant deleted the feat/improve-custom-handler-types branch December 7, 2023 08:43
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants