-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#377 Refactor: 기수 관련 UI 수정 및 추가 api 연결 #389
Open
dalzzy
wants to merge
16
commits into
develop
Choose a base branch
from
refactor#377/기수-관련-ui-수정-및-추가-api-연결
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "refactor#377/\uAE30\uC218-\uAD00\uB828-ui-\uC218\uC815-\uBC0F-\uCD94\uAC00-api-\uC5F0\uACB0"
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
347b3f8
style:#377 기수 추가 모달 ui 수정
dalzzy eb19ac2
refactor:#377 기수 추가 모달 ui 수정 및 유효성검사 추가
dalzzy 77c0296
Merge branch 'develop' of https://github.com/Leets-Official/Weeth-FE …
dalzzy 2ef759f
feat:#377 기수 클릭 시 해당 기수에 맞는 멤버만 필터링되도록 추가
dalzzy d3bb124
feat:#377 기수 수정 api 추가
dalzzy 908f6a9
fix: #377 선택한 기수로 상태가 변경되지 않는 문제 해결
dalzzy b11ad61
fix:#377 중복 모달 생성 문제 해결
dalzzy 73d6327
feat:#377 직접 입력 클릭시 모달 추가
dalzzy 41edcdd
refactor:#377 기수 추가 시 현재 활동 중인지 값을 추가하여 요청하도록 수정
dalzzy ecfa656
fix:#377 멤버의 최신 기수를 불러오지 못하는 오류 수정
dalzzy 3e9cdd5
refactor:#377 memberContext에서 기수를 비교하여 membershipType을 반환하도록 수정
dalzzy de0dd14
refactor:#377 기수 정보가 완전히 입력되지 않은 기수 컴포넌트의 ui 수정
dalzzy 79bce07
refactor:#377 기수 수정 api 연결
dalzzy 9a65830
refactor:#377 불필요한 값 제거
dalzzy c1c0dfa
refactor:#377 멤버 상세관리 모달 내의 기수 변경 모달 위치 수정
dalzzy b42b810
refactor:#377 페널티 페이지 기수 필터링 추가
dalzzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앞으로 추가해야할
api
들은 인스턴스 사용해서 적어줘도 좋을 것 같아요!!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네넴 알겠습니다! 어차피 api 연결은 이게 마지막이라... 새 이슈에서 한꺼번에 인스턴스 적용해볼게요!