Multi server configuration #3
Conversation
When multiple servers are used, the creation of aliases is only triggered on the server where the object is ingested. Configuration options are added so the creation of an alias triggers an action on another server that also creates the alias.
There was a problem hiding this comment.
Seems okay to me, although perhaps we should talk about variable naming some time :)
Have you tested all scenarios?
I do wonder about any differences between and Drupal community preferences about drupal_hash_base64 and drupal_hmac_base64. In any case, triggers should only use HTTPS and the secret should be long to prevent recovering the secret through eavesdropping the triggers and brute-forcing.
islandora_pathauto.module
Outdated
| $status = 401; | ||
| } | ||
|
|
||
| if ($success && ($op !== 'insert' && $op !== 'update')) { |
There was a problem hiding this comment.
You are a great code reviewer! Solved this in 24be51b
Thanks for code review again: I agree that long secrets and https will make it more secure. Do you think I need to make a check for both in code when entering in the form? And when a request is received? I could also check if time is within a few seconds of the current time? But this might be overkill, or not? |
I have implemented support for multiple servers when generating aliases for URL via pathauto.
An alias is generated when a new object is ingested into Islandora. Because we have an ingest server the alias is only made there. The public server does not get a trigger to generate an alias. With this PR it does get a trigger.
Please code review someone!