ignore move op for unresizable and skip_taskbar windows #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we've ignored skip-taskbar windows when trying to tile them (in TilingWindowManager.tile). The reason is that those windows probably shouldn't be allowed to be tiled, as they are usually stuff like modal dialogs etc. But at the moment we do show the tile preview for those windows, which gives the impression that we allow them to be tiled. I guess, we could allow skip-taskbar windows to be tiled (as long as they are resizable) but I think there may be more issues with them, e. g. when using modal dialogs that the parent window may be tiled but the dialog not. So I think it's better to just ignore them for now. attach-modal-dialogs settings is relevant to this issue. Closes #387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we've ignored skip-taskbar windows when trying to tile them (in TilingWindowManager.tile). The reason is that those windows probably shouldn't be allowed to be tiled, as they are usually stuff like modal dialogs etc. But at the moment we do show the tile preview for those windows, which gives the impression that we allow them to be tiled.
I guess, we could allow skip-taskbar windows to be tiled (as long as they are resizable) but I think there may be more issues with them, e. g. when using modal dialogs that the parent window may be tiled but the dialog not. So I think it's better to just ignore them for now. attach-modal-dialogs settings is relevant to this issue.
Closes #387