External redirection links and warning #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applied style to button directly Took 3 hours 30 minutes
Took 2 minutes
Took 54 seconds
…by a warning if it goes outside of the current site
Took 14 minutes
…nk component Took 26 minutes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RezaRahemtola
requested changes
Jul 20, 2024
| import LButton from "@/components/LButton.vue"; | ||
| import { ClassProp } from "class-variance-authority/types"; | ||
|
|
||
| interface IProps extends /* @vue-ignore */ LinkHTMLAttributes {} |
There was a problem hiding this comment.
Suggested change
| interface IProps extends /* @vue-ignore */ LinkHTMLAttributes {} | |
| interface LLinkProps extends LinkHTMLAttributes {} |
|
|
||
| withDefaults(defineProps<IProps & ClassProp>(), {}); | ||
|
|
||
| const open = ref(false); |
There was a problem hiding this comment.
Suggested change
| const open = ref(false); | |
| const isOpen = ref(false); |
|
|
||
| interface IProps extends /* @vue-ignore */ LinkHTMLAttributes {} | ||
|
|
||
| withDefaults(defineProps<IProps & ClassProp>(), {}); |
Comment on lines
+25
to
+29
| <LLink href="/company">Company</LLink> | ||
| <LLink href="/earn">Earn</LLink> | ||
| <LLink href="/developer">Developer</LLink> | ||
| <LLink href="/tokenomics">Tokenomics</LLink> | ||
| <LLink href="/Litepaper_0624_v2.pdf" target="_blank">Litepaper</LLink> |
There was a problem hiding this comment.
Not a fan of all of this, use LLink when needed but for basic RouterLink or <a> it just adds useless complexity when reading the code
| </p> | ||
| <a href="https://app.uniswap.org/explore/tokens/base/0xf8b1b47aa748f5c7b5d0e80c726a843913eb573a?chain=base"> | ||
| <LLink href="/design"> |
There was a problem hiding this comment.
wrong link, you removed the Uniswap link
|
The objective is to add links when we are redirecting to websites completely external to LibertAI as discussed on Figma (for Aleph staking etc), but not for our own websites/social networks etc. Maybe rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement the warning modal before redirecting the user to an external site (including other libertai subdomains.
It also adds a utility component that automatically choose & based on the href