-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to reflect current packages on offer on the download-site. #349
Conversation
The OR download page no longer uses the term "kit" for different packages. It also no longer offers a "traditional windows kit" without embedded java.
changes to reflect current packages on offer on the download-site.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-349 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-18 13:14:03 +0000 |
Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
I don't think there is the need for any further changes but just for complete clarity, OpenRefine itself does still offer It also the "windows without embedded java" option but only via Github and not on the download page. I mention only for completeness and do not suggest any further changes to the lesson |
You're absolutely right (although there does not seem to be a version without java for win from 3.8 onwards). I just thought since the lesson is referring to the download-page it would be confusing to mention things that are nowhere to be found there. Maybe I should have raised this as an issue first... |
I might have been too fast to approve. Thanks for starting the PR. I'll
move a bit slower.
…On Thu, Jun 20, 2024, 3:25 PM r0man-ist ***@***.***> wrote:
You're absolutely right (although there does not seem to be a version
without java for win from 3.8 onwards). I just thought since the lesson is
referring to the download-page it would be confusing to mention things that
are nowhere to be found there. Maybe I should have raised this as an issue
first...
—
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMT5MX5IG4EC3PLZRZO27PDZIM3EFAVCNFSM6AAAAABJQAP7YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGQ4TSOBYGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
@jas58 I think the outcome was the same - this is the right change so I don't think you were too hasty - good to get the update done quickly :) |
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via {sandpaper} Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via `{sandpaper}` Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via `{sandpaper}` Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via `{sandpaper}` Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
Auto-generated via `{sandpaper}` Source : 5bad9b5 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-19 20:50:36 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 26600d7 Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2024-06-19 20:49:49 +0000 Message : Merge pull request #349 from r0man-ist/main changes to reflect current packages on offer on the download-site.
The OR download page no longer uses the term "kit" for different packages. It also no longer offers a "traditional windows kit" without embedded java, as far as I can see.