Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

bump Lightning 2.1+ #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joao-alex-cunha
Copy link
Collaborator

@joao-alex-cunha joao-alex-cunha commented Nov 7, 2023

What does this PR do?

Makes lightning-Graphcore compatible with latest Lightning versions. Tested 2.1.1 and also master.
Note that I'm also using the latest Graphcore SDK (version 3.4)

There are a number of tests previously marked as failing that now pass.

A small caveat: in test test_warning_if_ipus_not_used the error message thrown by the Trainer has changed and I couldn't make the regex match. I believe it is to do with the quote marks. So I simplified the check to just verify if there is a UserWarning without verifying the error message itself.

closes #51

@Borda
Copy link
Member

Borda commented Nov 8, 2023

@joao-alex-cunha could you pls allow maintainers to edit the PR?
would need to resolve merge conflicts and complain with pre-commit...

@Borda Borda changed the title Lightning 2.1 bump Lightning 2.1+ Nov 16, 2023
@Borda
Copy link
Member

Borda commented Dec 1, 2023

@joao-alex-cunha how id it going here? :)

@joao-alex-cunha
Copy link
Collaborator Author

@Borda apologies for the delay. Between missing the first message and being busy working on other stuff, I could only get this done today. Thank you for your patience.

requirements/lightning.txt Outdated Show resolved Hide resolved
@joao-alex-cunha joao-alex-cunha enabled auto-merge (squash) December 5, 2023 15:04
@Borda
Copy link
Member

Borda commented Jan 24, 2024

@joao-alex-cunha could you pls run precommit on this PR, seems I can't push fix to your branch due to some protections coming with your fork repo... 🦩

@joao-alex-cunha
Copy link
Collaborator Author

Hi @Borda, I ran pre-commit and merged main onto this PR. Let me know if you need anything else.

@Borda
Copy link
Member

Borda commented Jan 29, 2024

I ran pre-commit and merged main onto this PR. Let me know if you need anything else.

It seems that the provided agents are offline, so we need to wait until they get back live and run tests...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants