Add nv_enable_options and nv_disable_options
#1432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
reviewed
Nov 13, 2024
|
Maybe @jjsjann123 or @kevinstephano would like to review this? |
jjsjann123
approved these changes
Nov 13, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Priya2698
force-pushed
the
pm/nvf_options
branch
from
ba56a4e
to
f60ad93
Compare
for more information, see https://pre-commit.ci
jjsjann123
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvFuser version >= 0.2.23will support settingNVFUSER_ENABLE/NVFUSER_DISABLEthrough the python frontend using_enable_optionsand_disable_optionsflags. This is to enable matmul/linear codegen for nvfuser through Thunder using flagsnv_enable_options=["fuse_matmul"], nv_disable_options=["matmul_expr_eval"]Issue: NVIDIA/Fuser#3022
nvFuser PR: NVIDIA/Fuser#3270