fix macro when ignore_index is set
#2163
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edumotya
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Borda
changed the title
ignore_index is set
SkafteNicki
reviewed
Oct 17, 2023
| @@ -416,6 +416,8 @@ def _multiclass_stat_scores_update( | |||
| fp = confmat.sum(0) - tp | |||
| fn = confmat.sum(1) - tp | |||
| tn = confmat.sum() - (fp + fn + tp) | |||
| if ignore_index is not None: | |||
| fp[ignore_index] = 0 | |||
There was a problem hiding this comment.
this is probably correct, but since many metrics derive from the stat_scores class that means that basically all would need to have their unittests fixed
There was a problem hiding this comment.
what do you mean by it needs to be fixed?
|
@edumotya how is it going, mind checking comment from Nicki |
|
@edumotya seems like most of the tests are off; could you pls check it... |
|
sure @Borda, I am sorry for the late response. It might take me some time, it is not straightforward to fix the affected tests, I'll do my best |
|
Any update? |
Borda
force-pushed
the
master
branch
2 times, most recently
from
d0a5568
to
9fc79ae
Compare
I think this is related #2710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1691
Additionally, tests have been updated to exclude the ignored class from the macro accuracy averaging.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2163.org.readthedocs.build/en/2163/