-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added mathjax for rendering tex format as imgmath needs latex engine to run #316
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
===================================
Coverage 70% 70%
===================================
Files 2 2
Lines 403 403
===================================
Hits 284 284
Misses 119 119 |
@Borda Just a quick question: I'm trying to build docs from this repository, but tutorials seem to fail on the main branch, when I try from the pytorch-lightning repository where this is added as a submodule the changes seem to work there, does it mean that if we update the submodule? I can see that the submodule branch is Does this mean that the PR has to be merged to the publication branch? Just an update built docs from the |
yes when you clone this repo recursively you shall get the right branch |
Then I think these changes have to be made on the |
d4acf6f
to
ac8f7ba
Compare
Before submitting
What does this PR do?
Adding support to render latex math formulas, changing from
imgmath
tomathjax
asimgmath
requires latex engine to run.related to Lightning-AI/pytorch-lightning#19633
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃