Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update mypy check #288

Merged
merged 4 commits into from
Jul 18, 2024
Merged

ci: update mypy check #288

merged 4 commits into from
Jul 18, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 18, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

mypy
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/Lightning-AI/lightning-app/actions/runs/9991062745/job/27613090126?pr=979#step:8:3).9.19/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.19/x6[4](https://github.com/Lightning-AI/lightning-app/actions/runs/9991062745/job/27613090126?pr=979#step:8:4)/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.19/x[6](https://github.com/Lightning-AI/lightning-app/actions/runs/9991062745/job/27613090126?pr=979#step:8:6)4
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.19/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.19/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.19/x64/lib
error: --install-types failed (no mypy cache directory)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--288.org.readthedocs.build/en/288/

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Jul 18, 2024
@Borda Borda requested a review from awaelchli as a code owner July 18, 2024 13:18
@Borda Borda merged commit 40360ed into main Jul 18, 2024
45 checks passed
@Borda Borda deleted the ci/mypy branch July 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant