Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update script with dynamic torch-ecosystem versions determinations #318

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 18, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

With this change we do not face critical CI failure after each Torch release and need of manual version bumping unless there is and exception

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--318.org.readthedocs.build/en/318/

@Borda Borda added enhancement New feature or request priority: 1 Medium priority task dependencies labels Oct 18, 2024
@Borda Borda enabled auto-merge (squash) October 18, 2024 19:34
Copy link

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! should add tests too.

@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Oct 18, 2024
@Borda Borda disabled auto-merge October 18, 2024 20:15
@Borda Borda merged commit 1d0e380 into main Oct 18, 2024
52 checks passed
@Borda Borda deleted the versions branch October 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration and delivery dependencies enhancement New feature or request priority: 1 Medium priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants