Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cli commands and options #15

Merged
merged 14 commits into from
Aug 8, 2023
Merged

Refactor/cli commands and options #15

merged 14 commits into from
Aug 8, 2023

Conversation

dimitrovmaksim
Copy link
Member

@dimitrovmaksim dimitrovmaksim commented Aug 3, 2023 •
edited
Loading

  1. Refactors the CLI:
    1. Removes Nothing injection
    2. Renames JibberishReturnValue to BadReturnValue
    3. Adds inject and convert subcommands
  2. Updates the Julia script to accepts the host as command line argument and execute only the tests for the specified host
  3. Updates the Zombienet workflow. Now the zombienet tests will execute also if the workflow or any of the test files get changed
  4. Adds Rust workflow to execute cargo fmt, clippy and test
  5. Updates the Readme

@dimitrovmaksim
refactor(cli)!: Remove nothing injection. Add inject and decode subco…
2c670dc 
…mmads

Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
chore(tests): Remove stack_limiter tests
83b48a1 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
refactor(cli): Fix naming when no destination file is passed
30c4dfe 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
ci: Add github workflow for crago test, fmt, clippy
493f1b6 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
chore(cargo): Update clap version
993f119 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
Make the julia script to execute tests for a specific host only
5ee9079 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
Merge branch 'develop' into refactor/cli-commands-and-options
2ed0934
@dimitrovmaksim
refactor(cli): Rename Decode to Convert. Add convert options
b12263c 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
Update the workflow
1de5180 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim dimitrovmaksim changed the base branch from develop to master August 7, 2023 12:04
@dimitrovmaksim dimitrovmaksim changed the base branch from master to develop August 7, 2023 12:04
@dimitrovmaksim dimitrovmaksim force-pushed the refactor/cli-commands-and-options branch from 143ab5c to 694250f Compare August 7, 2023 12:43
@dimitrovmaksim
chore(cli): Update help messages
fa3e111 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
ci: Remove base_ref check
c23f0ab 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
chore(readme): Update readme
4fb8d43 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim
chore(readme): Update folder name
e451115 
Signed-off-by: Maksim Dimitrov <[email protected]>
@dimitrovmaksim dimitrovmaksim marked this pull request as ready for review August 7, 2023 13:38
@dimitrovmaksim dimitrovmaksim self-assigned this Aug 7, 2023
@dimitrovmaksim dimitrovmaksim added the enhancement New feature or request label Aug 7, 2023
@dimitrovmaksim dimitrovmaksim merged commit ace8771 into develop Aug 8, 2023
3 checks passed
@dimitrovmaksim dimitrovmaksim deleted the refactor/cli-commands-and-options branch August 8, 2023 05:59
dimitrovmaksim added a commit that referenced this pull request Aug 11, 2023
@dimitrovmaksim
Refactor/cli commands and options (#15)
4bf9152 
* refactor(cli)!: Remove nothing injection. Add inject and decode subcommads

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(tests): Remove stack_limiter tests

Signed-off-by: Maksim Dimitrov <[email protected]>

* refactor(cli): Fix naming when no destination file is passed

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Add github workflow for crago test, fmt, clippy

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(cargo): Update clap version

Signed-off-by: Maksim Dimitrov <[email protected]>

* Make the julia script to execute tests for a specific host only

Signed-off-by: Maksim Dimitrov <[email protected]>

* refactor(cli): Rename Decode to Convert. Add convert options

Signed-off-by: Maksim Dimitrov <[email protected]>

* Update the workflow

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Trigger zombienet workflow on changes to tests or main.taml

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(cli): Update help messages

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Remove base_ref check

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(readme): Update readme

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(readme): Update folder name

Signed-off-by: Maksim Dimitrov <[email protected]>

---------

Signed-off-by: Maksim Dimitrov <[email protected]>
dimitrovmaksim added a commit that referenced this pull request Aug 11, 2023
@dimitrovmaksim
Refactor/cli commands and options (#15)
d3f2566 
* refactor(cli)!: Remove nothing injection. Add inject and decode subcommads

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(tests): Remove stack_limiter tests

Signed-off-by: Maksim Dimitrov <[email protected]>

* refactor(cli): Fix naming when no destination file is passed

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Add github workflow for crago test, fmt, clippy

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(cargo): Update clap version

Signed-off-by: Maksim Dimitrov <[email protected]>

* Make the julia script to execute tests for a specific host only

Signed-off-by: Maksim Dimitrov <[email protected]>

* refactor(cli): Rename Decode to Convert. Add convert options

Signed-off-by: Maksim Dimitrov <[email protected]>

* Update the workflow

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Trigger zombienet workflow on changes to tests or main.taml

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(cli): Update help messages

Signed-off-by: Maksim Dimitrov <[email protected]>

* ci: Remove base_ref check

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(readme): Update readme

Signed-off-by: Maksim Dimitrov <[email protected]>

* chore(readme): Update folder name

Signed-off-by: Maksim Dimitrov <[email protected]>

---------

Signed-off-by: Maksim Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikirov mikirov mikirov approved these changes

@vikinatora vikinatora Awaiting requested review from vikinatora

Assignees

@dimitrovmaksim dimitrovmaksim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitrovmaksim @mikirov