Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable liberty dev mode for fhir-server-webapp #2328

Merged
merged 9 commits into from
Dec 7, 2021
Merged

enable liberty dev mode for fhir-server-webapp #2328

merged 9 commits into from
Dec 7, 2021

Conversation

lmsurpre
Copy link
Member

Signed-off-by: Lee Surprenant [email protected]

@lmsurpre lmsurpre force-pushed the liberty-dev-mode branch 2 times, most recently from 4e4cdf6 to c7af521 Compare September 13, 2021 12:19
@lmsurpre lmsurpre force-pushed the liberty-dev-mode branch 5 times, most recently from bba63a2 to 4795f26 Compare September 23, 2021 20:42
@lmsurpre lmsurpre force-pushed the liberty-dev-mode branch 4 times, most recently from 8933449 to 65899a6 Compare November 29, 2021 12:25
@lmsurpre lmsurpre marked this pull request as ready for review December 2, 2021 22:30
prb112
prb112 reviewed Dec 3, 2021
View reviewed changes
fhir-persistence-scout/pom.xml
@@ -18,6 +18,26 @@

<build>
<plugins>
<plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad Merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually here on purpose, but its only tangentially related to the rest of the PR.
basically, I was trying to use liberty dev mode in vscode. without this plugin, our experimental fhir-persistence-scout project fails to compile in vscode (because the classes in there depend on this one generated class that winds up in generated-sources). the config here tells vscode to add the folder as a source folder.

Copy link
Member Author

@lmsurpre lmsurpre Dec 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see redhat-developer/vscode-java#177 for a long sordid history..

prb112
prb112 reviewed Dec 3, 2021
View reviewed changes
fhir-server-webapp/src/main/liberty/config/bootstrap.properties
@@ -0,0 +1,3 @@
javax.xml.stream.XMLInputFactory=com.sun.xml.internal.stream.XMLInputFactoryImpl
javax.xml.stream.XMLOutputFactory=com.sun.xml.internal.stream.XMLOutputFactoryImpl
javax.xml.stream.XMLTransformerFactory=com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a README in the prior location that tells people where to look now?

Copy link
Member Author

@lmsurpre lmsurpre Dec 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: https://github.com/IBM/FHIR/blob/0fafef4c4a8b0f5744d420c2141989cabd67c196/fhir-server/liberty-config/README.txt

prb112
prb112 approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one comment.... README.md to mark the fact the folder changed.
2. it'd be great if there is some how-to docs updated in the dev wiki

@lmsurpre
Copy link
Member Author

lmsurpre commented Dec 3, 2021

  1. it'd be great if there is some how-to docs updated in the dev wiki

Yes, if we merge this then we'll definitely need to make a few dev wiki updates. I will plan on it.

michaelwschroeder
michaelwschroeder approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre
enable liberty dev mode for fhir-server-webapp
3ee9a83 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
move remaining liberty-config artifacts to fhir-server-webapp
e2a8785 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
declare maven-dependency-plugin in fhir-parent and bump version
f1b2d72 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
Use liberty maven plugin copyDependencies feature
dc5121c 
instead of maven-dependency-plugin

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
update migration test scripts to handle old config location
66cec0b 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
minor edits to fhir-persistence-scout to make it compile
e26ff3e 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
Move last couple files and added README
51ca9a6 
Per review comment

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
update to latest plugin version
07c657f 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
change default derby location to the root of the project
36492f8 
and add that location (and schematool log files) to .gitignore

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre lmsurpre merged commit cb106bc into main Dec 7, 2021
@lmsurpre lmsurpre deleted the liberty-dev-mode branch December 7, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwschroeder michaelwschroeder michaelwschroeder approved these changes

@prb112 prb112 prb112 approved these changes

@punktilious punktilious Awaiting requested review from punktilious

@tbieste tbieste Awaiting requested review from tbieste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmsurpre @prb112 @michaelwschroeder