fix(match2): valorant participant issue in legacy #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbergen
approved these changes
Sep 17, 2024
hjpalpha
reviewed
Sep 17, 2024
hjpalpha
approved these changes
Sep 17, 2024
|
Can it really have gaps if it's being build with Array.extractValues? Or are you referring to potential other sources than the one introduced with the preceding PR? |
|
The one in from recordFromGame is using extractValues. hjp is talking about the one now built in MatchGroupInput/Custom. Which could allow for gaps (it either needs gaps or force empty tables at certain participants) |
hjpalpha
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
game.opponentsas an input format, which is automatically remapped intogame.participantsfor storage.This allows access to
game.opponentsin Match/Legacy, just like in MatchSummary.How did you test this change?
/dev