Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infobox): implement valve tier for dota2 wiki #5035

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Conversation

iMarbot
Copy link
Collaborator

@iMarbot iMarbot commented Nov 5, 2024

Summary

Dota2 specific version of #4976 which mostly copies valve tier stuff from CS wiki, as voted for in discord dota2 channel. Once deployed, will need a bot run to replace |pctier= with |valvetier= and to change the appropriate inputs to match new tiers.

How did you test this change?

Will be tested via dev deploy soon.

@iMarbot iMarbot requested a review from hjpalpha November 5, 2024 22:38
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable on phone

@Rathoz
Copy link
Collaborator

Rathoz commented Nov 6, 2024

Can we use the input publishertier instead?

@Rathoz Rathoz changed the title feat(infobx): implement valve tier for dota2 wiki feat(infobox): implement valve tier for dota2 wiki Nov 6, 2024
@iMarbot
Copy link
Collaborator Author

iMarbot commented Nov 6, 2024

Can we use the input publishertier instead?

Would be a question for dota2 editors imo.

@Rathoz Rathoz merged commit 8d2130e into main Nov 7, 2024
5 checks passed
@Rathoz Rathoz deleted the dota-valve-tier branch November 7, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants