-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infobox): implement valve tier for dota2 wiki #5035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMarbot
added
c: infobox
c: standard
g: dota2
DOTA2
c: hidden_data_box
c: prize_pool
labels
Nov 5, 2024
hjpalpha
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable on phone
Can we use the input |
Rathoz
changed the title
feat(infobx): implement valve tier for dota2 wiki
feat(infobox): implement valve tier for dota2 wiki
Nov 6, 2024
Would be a question for dota2 editors imo. |
Rathoz
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dota2 specific version of #4976 which mostly copies valve tier stuff from CS wiki, as voted for in discord dota2 channel. Once deployed, will need a bot run to replace
|pctier=
with|valvetier=
and to change the appropriate inputs to match new tiers.How did you test this change?
Will be tested via dev deploy soon.