Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mainpage): new Overwatch main page #5319

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

feat(mainpage): new Overwatch main page #5319

wants to merge 16 commits into from
+240 −0

Conversation

ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Jan 14, 2025 •
edited
Loading

Summary

This PR standardizes main page layout of Overwatch wiki.

Credit for initial work done for this PR goes to @elisazanatta

Checklist

  • Select images for navigation cards
  • Lint

How did you test this change?

@ElectricalBoy ElectricalBoy marked this pull request as ready for review January 14, 2025 15:39
@ElectricalBoy ElectricalBoy self-assigned this Jan 15, 2025
@Rathoz Rathoz changed the title feat(mainpage): Standardize Overwatch main page feat(mainpage): new Overwatch main page Jan 15, 2025
@ElectricalBoy ElectricalBoy requested a review from Rathoz January 15, 2025 11:16
@Rathoz
Copy link
Collaborator

Rathoz commented Jan 15, 2025

image

Transfers header looks kinda scruffed

@ElectricalBoy
Copy link
Collaborator Author

ElectricalBoy commented Jan 15, 2025 •
edited
Loading

Transfers header looks kinda scruffed

that second header is actually part of overwatch:Liquipedia:News/Transfers and can be removed by editing the transcluded page directly
but since it is part of the current mainpage I don't really want to make the change until this PR is merged

nvm; see 4269eca

@ElectricalBoy ElectricalBoy marked this pull request as draft January 15, 2025 13:38
@ElectricalBoy
Copy link
Collaborator Author

converting back to draft as we are finalizing photos in Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamentry iamentry iamentry left review comments

@GeneralHuber GeneralHuber GeneralHuber left review comments

@Rathoz Rathoz Awaiting requested review from Rathoz

At least 1 approving review is required to merge this pull request.

Assignees

@ElectricalBoy ElectricalBoy

Labels
c: main_page g: overwatch Overwatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ElectricalBoy @Rathoz @GeneralHuber @iamentry @elisazanatta @hjpalpha