perf: improve memory performance of match ticker #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Jan 15, 2025
Rathoz
force-pushed
the
perf-match-ticker-mem
branch
from
fb011b1 to
3a95222
Compare
hjpalpha
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves memory performance of the match ticker, and also ensures that it will always find results (well, limiting it to 20 queries)
How did you test this change?
Functionally works.
Is more efficient when it comes to post filters (can actually retrieve all matches up to limit). And does that without breaking the memory bank.
As example, just as efficient on all wikis. With a region filter with which exists 45 matches in the future of on LoL, new version could find them all, while existing version only fetched 35.