Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTTPS proxy to work off redirects towards an external proxy #668

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented Sep 25, 2024

This allows us to use an external proxy, instead of the buggy proxy that I had originally written. Sadly we cant redirect directly to prod because of a bug in the original game (after a redirect it still uses the pre-redirect host header value with the new server).

In practice, the proxy.json config will probably just point to the same machine as Refresh.HttpsProxy itself, but with a different port, which is hosting a standard nginx HTTP proxy server.

This PR also fixes the middleware order

@Beyley Beyley requested a review from jvyden September 25, 2024 02:34
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this PR flew under the radar

@jvyden jvyden merged commit b5b8a17 into LittleBigRefresh:main Oct 5, 2024
4 checks passed
@Beyley Beyley deleted the https-proxy-fix branch October 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants