Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec Draft #3
base: main
Are you sure you want to change the base?
Spec Draft #3
Changes from 31 commits
75ae5fd
46cd4c3
edeaec0
95a7e13
366fbb9
3c7397e
9f35009
9b64276
1525262
7e6224a
93901c8
692328a
8b6d647
675e1ae
32267f6
1aab040
826b54a
b2ec9aa
6382396
89d8ba2
9594d08
6b1e94c
2d5c379
025bb89
dd23ff7
f1b3987
9a85990
54bfebd
a904ac9
0cb9326
4e9ae6c
0ff36e7
d2d67f9
7d94cb2
b1a5a88
93c7956
141da66
439c88b
40ab8d4
bf2ebe9
179e968
664a256
7f9a373
0540142
993f2d4
c410cbe
9f2d98b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the description of the method/function should be side of its own definition instead of the place you call it.