Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeezyMatch training requires training dataset to exist even if training is skipped #215

Closed
mcollardanuy opened this issue Apr 26, 2023 · 0 comments · Fixed by #233
Closed
Assignees
Labels
bug Something isn't working candidate selection

Comments

@mcollardanuy
Copy link
Collaborator

mcollardanuy commented Apr 26, 2023

Currently, if a DeezyMatch model already exists, the Ranker (when in "deezymatch" mode) still goes through the code to generate a training set for DeezyMatch. It shouldn't, because we already have a DeezyMatch model. This may cause an error if we use DeezyMatch with an already trained DeezyMatch model in an inference setting only (i.e. in a location where we haven't run the training), because the code looks for the resources to generate a training set, even if we don't provide them because we already provided the trained model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working candidate selection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant