Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip create trainset if deezy model exists #233

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

mcollardanuy
Copy link
Collaborator

Hi @lukehare,

Could you have a look at this PR? It addresses this issue. One way to test this should be to run train_use_deezy_model_3.ipynb, which, if I am not mistaken, should work with only the following resources (you can copy them from my local folder in toponymVM2.0):

  • resources/wikidata/mentions_to_wikidata.json
  • resources/wikidata/wikidata_gazetteer.csv
  • resources/wikidata/mentions_to_wikidata_normalized.json
  • resources/wikidata/wikidata_to_mentions_normalized.json
  • resources/deezymatch/combined/wkdtalts_w2v_ocr/
  • resources/deezymatch/models/w2v_ocr/
  • resources/models/blb_lwm-ner-fine.model/

Thanks!

Copy link
Collaborator

@lukehare lukehare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukehare lukehare merged commit c3b4ea0 into dev Jul 26, 2023
2 checks passed
@mcollardanuy mcollardanuy deleted the 215-bug-deezy-requires-dataset branch July 26, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeezyMatch training requires training dataset to exist even if training is skipped
2 participants