-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: don't update locked fields + unlock fields after update #208
Conversation
3ec2750
to
bc41508
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## nightly #208 +/- ##
===========================================
- Coverage 67.75% 66.47% -1.29%
===========================================
Files 11 11
Lines 856 874 +18
===========================================
+ Hits 580 581 +1
- Misses 276 293 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are the final adjustments. Also need to add a test for is_field_locked
, I can take care of that if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is now a method for plex item objects in plexapi.
Getting several timeout errors with the new api version. Also, it is often saying "Not overwriting locked theme for movie: ...". |
90f3eb0
to
4788a4b
Compare
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
4788a4b
to
54b534f
Compare
Co-authored-by: ReenigneArcher <[email protected]>
2edba80
to
a89b952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to use a retry loop; tested it on my local setup by introducing fake timeouts (just maxed out my IO usage so Plex would be slowed down, and the loop properly retried and failed gracefully at the first attempt instead of crashing the plugin
Description
Locked fields will not be updated by Themerr. Fields updated by Themerr will be marked as non-locked.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.