This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix(yt-dl): validate audio url and add retry logic #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
commented
Jul 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 67.98% 69.55% +1.56%
==========================================
Files 12 12
Lines 1087 1120 +33
==========================================
+ Hits 739 779 +40
+ Misses 348 341 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
referenced
this pull request
in ytdl-org/youtube-dl
Jul 26, 2024
ReenigneArcher
commented
Jul 26, 2024
ReenigneArcher
commented
Jul 26, 2024
ReenigneArcher
force-pushed
the
ReenigneArcher-patch-1
branch
from
July 26, 2024 20:20
2ac6f14
to
a19ca39
Compare
ReenigneArcher
changed the title
tests: increase time to wait for themes
tests: fix unit tests
Jul 26, 2024
ReenigneArcher
force-pushed
the
ReenigneArcher-patch-1
branch
9 times, most recently
from
July 27, 2024 21:14
fda0e82
to
978b1f0
Compare
ReenigneArcher
changed the title
tests: fix unit tests
fix(yt-dl): validate audio url and add retry logic
Jul 27, 2024
ReenigneArcher
force-pushed
the
ReenigneArcher-patch-1
branch
from
July 28, 2024 02:22
978b1f0
to
20c9f0b
Compare
11 tasks
ReenigneArcher
force-pushed
the
ReenigneArcher-patch-1
branch
from
August 9, 2024 19:21
81df3d2
to
e71e641
Compare
Quality Gate passedIssues Measures |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging #481 there are issues with YouTube urls.
It seems the urls provided by youtube are inaccessible due to 403 errors. When these are sent to Plex, a 406 response is given. See ytdl-org/youtube-dl#32882 for more info.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.