darwin-uninstaller: remove darwin channel from root too
#1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samasaur1
approved these changes
Jan 20, 2025
Enzime
approved these changes
Jan 21, 2025
|
If I remember correctly that check was meant to be is the installed version of nix-daemon the same as the one in your current system closure but I’m not entirely sure |
|
Makes sense. I guess it can wait until another time to figure out what it should be doing :) Though shouldn’t it be testing the opposite, i.e. the Nix from the system closure is no longer being used…? |
|
Or possibly it was to check that it matches the one from your system profile ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle this now that we recommend people use
sudo nix-channel --add. I’m not sure~/.nix-defexpris always used (e.g. with XDG directories?), so we just remove it unconditionally in both user and system activation and hope the warning isn’t too bothersome, but maybe we could do something smarter here.@Enzime I don’t suppose you have any idea what the
[[ "$(shasum -a 256 /Library/LaunchDaemons/org.nixos.nix-daemon.plist | awk '{print $1}')" == "$(shasum -a 256 /Library/LaunchDaemons/org.nixos.nix-daemon.plist | awk '{print $1}')" ]]thing from 3a89b61 is about?