Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin-rebuild: pass ${extraBuildFlags[@]} to nix-instantiate #1281

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

emilazy
Copy link
Collaborator

@emilazy emilazy commented Jan 18, 2025

Theoretically required for darwin-rebuild edit -I darwin-config=…, I guess. We also shouldn’t run it for flake‐based setups.

Theoretically required for `darwin-rebuild edit -I darwin-config=…`,
I guess. We also shouldn’t run it for flake‐based setups.
@emilazy emilazy requested a review from Enzime January 18, 2025 20:02
Copy link
Contributor

@Samasaur1 Samasaur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure when this would be necessary (mostly because I have never used darwin-rebuild edit but given that you can pass any Nix options you want to the script, we might as well pass them along

@emilazy emilazy merged commit 3cdacf1 into LnL7:master Jan 21, 2025
3 checks passed
@emilazy emilazy deleted the push-ozqwkmtmkvtr branch January 21, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants