Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turnstile #36

Closed
wants to merge 3 commits into from
Closed

Add Turnstile #36

wants to merge 3 commits into from

Conversation

Muska-Ami
Copy link
Member

@Muska-Ami Muska-Ami commented Nov 30, 2024

See LoCyan-Team/LoCyanFrpAPI-v2#21

Copy link

cloudflare-workers-and-pages bot commented Nov 30, 2024

Deploying locyanfrp-panel-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8624625
Status: ✅  Deploy successful!
Preview URL: https://5a312066.locyanfrppanel.pages.dev
Branch Preview URL: https://dev-turnstile.locyanfrppanel.pages.dev

View logs

@NanamiNakano NanamiNakano self-requested a review November 30, 2024 14:13
// window.location.host +
// '/auth/login'
// }
watch(token, (oldToken, newToken) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using watch hook is not a good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Astrian/cfturnstile-vue3 offered a callback event, which allows us avoid the use of watch hook.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already tested this package, it can't reset the captcha widget after the n-model re-rendered, will case unexpectedly behavior.

@@ -33,6 +33,7 @@
"vue-native-websocket": "^2.0.15",
"vue-route": "^1.5.1",
"vue-router": "^4.4.5",
"vue-turnstile": "^1.0.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using https://github.com/Astrian/cfturnstile-vue3
vue-turnstile is designed for Vue 2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruigomeseu/vue-turnstile

It's designed for Vue 3 instead of Vue 2, if you have any questions about the Options API, please refer to: https://cn.vuejs.org/guide/introduction.html#options-api

@Muska-Ami Muska-Ami closed this Dec 2, 2024
@Muska-Ami Muska-Ami deleted the dev-turnstile branch December 27, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants